From c9c3b88f4de875fac777384af57cb96def622204 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 12:39:16 +0200
Subject: [PATCH 1/6] style: apply editorconfig

---
 resources/views/front/index.blade.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/resources/views/front/index.blade.php b/resources/views/front/index.blade.php
index e68b58e..9e390ef 100644
--- a/resources/views/front/index.blade.php
+++ b/resources/views/front/index.blade.php
@@ -1,4 +1,4 @@
-@extends('frame') 
+@extends('frame')
 @section('title', 'This is The Bad Space')
   @section('main-content')
     @parent
@@ -55,4 +55,4 @@
         </table>
       </article>
     </section>
-  @endsection
\ No newline at end of file
+  @endsection

From 3e070676e4f9ccad2015b5b4331eca64a44c75b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 17:03:41 +0200
Subject: [PATCH 2/6] feat: add accessible form element focus indicator
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

adds a focus indicator that passes the accessibility requirements WCAG 2.2: §1.4.11 & §2.4.7
---
 public/assets/css/front/index.css  |  6 ++++++
 public/assets/css/global/forms.css | 10 +++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/public/assets/css/front/index.css b/public/assets/css/front/index.css
index f73f367..ec9b25b 100644
--- a/public/assets/css/front/index.css
+++ b/public/assets/css/front/index.css
@@ -3,6 +3,12 @@ section.index-search {
   background: var(--white);
 }
 
+/* TODO: move to a global file? it’s not only for forms. */
+section.index-search :focus-visible {
+  outline: 2px solid var(--white);
+  outline-offset: -4px;
+}
+
 section.start a.search-link {
   color: var(--highlight);
   font-size: 2.5em;
diff --git a/public/assets/css/global/forms.css b/public/assets/css/global/forms.css
index f965472..7d7ec02 100644
--- a/public/assets/css/global/forms.css
+++ b/public/assets/css/global/forms.css
@@ -14,10 +14,18 @@ input[type="text"] {
 
 input[type="text"]:focus,
 input[type="password"]:focus {
-  outline: solid var(--highlight);
   background-color: var(--highlight);
 }
 
+/* TODO: generalise this a bit */
+button:focus,
+input[type="submit"]:focus,
+input[type="text"]:focus,
+input[type="password"]:focus {
+  outline: 2px solid var(--white);
+  outline-offset: -4px;
+}
+
 textarea {
   border: 0;
   border-radius: 3px;

From d165d0c2bdba12e718a8dcff8c942334cc1a51e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 17:23:49 +0200
Subject: [PATCH 3/6] feat: replace search icon with an SVG

this change allows us to use the font colour for the icon. it might also be nice to use a sprite.svg for all icons. this would use the same <use> mechanism as i did here.

this also optimises the SVG a bit
---
 public/assets/css/front/index.css           |  9 +++------
 public/assets/images/global/icon-search.svg | 10 +++-------
 resources/views/front/index.blade.php       |  4 +++-
 3 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/public/assets/css/front/index.css b/public/assets/css/front/index.css
index ec9b25b..e5c2d20 100644
--- a/public/assets/css/front/index.css
+++ b/public/assets/css/front/index.css
@@ -38,8 +38,9 @@ form.index-search-form > button {
   right: 0;
 }
 
-form.index-search-form > button > img#search-icon {
-  float: none;
+form.index-search-form > button > svg {
+  width: 48px;
+  height: 48px;
 }
 
 form.index-search-form > button > label {
@@ -116,8 +117,4 @@ table.index-meta td {
   form.index-search-form > button > label {
     display: inline;
   }
-
-  form.index-search-form > button > img#search-icon {
-    float: right;
-  }
 }
diff --git a/public/assets/images/global/icon-search.svg b/public/assets/images/global/icon-search.svg
index 47a3125..d41cc54 100644
--- a/public/assets/images/global/icon-search.svg
+++ b/public/assets/images/global/icon-search.svg
@@ -1,8 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated by Pixelmator Pro 3.3.8 -->
-<svg width="101" height="100" viewBox="0 0 101 100" xmlns="http://www.w3.org/2000/svg">
-    <g id="Group-copy">
-        <path id="Path-copy-2" fill="none" stroke="#efebe3" stroke-width="8.777778" stroke-linecap="round" stroke-linejoin="round" d="M 11 41.722221 C 11 58.68964 24.754808 72.444443 41.722221 72.444443 C 58.68964 72.444443 72.444443 58.68964 72.444443 41.722221 C 72.444443 24.754807 58.68964 11 41.722221 11 C 24.754808 11 11 24.754807 11 41.722221"/>
-        <path id="Path-copy" fill="none" stroke="#efebe3" stroke-width="8.777778" stroke-linecap="round" stroke-linejoin="round" d="M 90 90 L 63.666668 63.666668"/>
-    </g>
+<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg" id="search">
+    <path fill="none" stroke="currentcolor" stroke-width="8.777778" stroke-linecap="round" stroke-linejoin="round" d="M 11 41.722221 C 11 58.68964 24.754808 72.444443 41.722221 72.444443 C 58.68964 72.444443 72.444443 58.68964 72.444443 41.722221 C 72.444443 24.754807 58.68964 11 41.722221 11 C 24.754808 11 11 24.754807 11 41.722221"/>
+    <path fill="none" stroke="currentcolor" stroke-width="8.777778" stroke-linecap="round" stroke-linejoin="round" d="M 90 90 L 63.666668 63.666668"/>
 </svg>
diff --git a/resources/views/front/index.blade.php b/resources/views/front/index.blade.php
index 9e390ef..f63c242 100644
--- a/resources/views/front/index.blade.php
+++ b/resources/views/front/index.blade.php
@@ -7,7 +7,9 @@
         <input type="text" name="index_search" value="" placeholder="Hi! This is where you search." />
         <button aria-label="search-button">
           <label id="search-label">LOOK FOR IT</label>
-          <img id="search-icon" class="button-icon" src="assets/images/global/icon-search.svg" />
+          <svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg" role="img" aria-hidden="trye">
+              <use href="assets/images/global/icon-search.svg#search" />
+          </svg>
         </button>
         @csrf
       </form>

From 4dafad447dd70a478c9fb40934813c2fb0fe130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 17:32:42 +0200
Subject: [PATCH 4/6] fix: set accessible name for search button

also changes the CSS for the text transform
---
 public/assets/css/front/index.css     | 1 +
 resources/views/front/index.blade.php | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/public/assets/css/front/index.css b/public/assets/css/front/index.css
index e5c2d20..36b1194 100644
--- a/public/assets/css/front/index.css
+++ b/public/assets/css/front/index.css
@@ -36,6 +36,7 @@ form.index-search-form > button {
   position: relative;
   top: 9px;
   right: 0;
+  text-transform: uppercase;
 }
 
 form.index-search-form > button > svg {
diff --git a/resources/views/front/index.blade.php b/resources/views/front/index.blade.php
index f63c242..13d5d34 100644
--- a/resources/views/front/index.blade.php
+++ b/resources/views/front/index.blade.php
@@ -5,8 +5,8 @@
     <section class="index-search">
       <form class="index-search-form" action="/search" method="post" enctype="multipart/form-data">
         <input type="text" name="index_search" value="" placeholder="Hi! This is where you search." />
-        <button aria-label="search-button">
-          <label id="search-label">LOOK FOR IT</label>
+        <button aria-labelledby="search-label">
+          <span id="search-label">Look for it</span>
           <svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg" role="img" aria-hidden="trye">
               <use href="assets/images/global/icon-search.svg#search" />
           </svg>

From 04ac27ea04b0d3815e6ab45bdf83a256df6bddad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 17:44:21 +0200
Subject: [PATCH 5/6] fix: only transition form control colors

the blanket statement `all` causes some weird animations when resizing the page. setting this to only transition specific properties fixes this.
---
 public/assets/css/global/forms.css | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/public/assets/css/global/forms.css b/public/assets/css/global/forms.css
index 7d7ec02..26caf39 100644
--- a/public/assets/css/global/forms.css
+++ b/public/assets/css/global/forms.css
@@ -8,7 +8,8 @@ input[type="text"] {
   display: inline-block;
   background: var(--white);
   color: var(--primary);
-  transition: all 0.2s linear;
+  transition: 0.2s linear;
+  transition-property: color, background-color;
   height: 30px;
 }
 
@@ -42,7 +43,8 @@ input[type="submit"] {
   position: relative;
   cursor: pointer;
   border: 0;
-  transition: all 0.3s linear;
+  transition: 0.3s linear;
+  transition-property: color, background-color;
   height: 35px;
   margin-top: 15px;
 }

From fed874892387087e931d63aac8afd7f7e130f0e7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zo=C3=AB?= <code@moiety.me>
Date: Fri, 2 May 2025 17:49:46 +0200
Subject: [PATCH 6/6] refactor: rework the search form with CSS Grid

---
 public/assets/css/front/index.css | 62 ++++++++++++++++++++-----------
 1 file changed, 41 insertions(+), 21 deletions(-)

diff --git a/public/assets/css/front/index.css b/public/assets/css/front/index.css
index 36b1194..496a9c5 100644
--- a/public/assets/css/front/index.css
+++ b/public/assets/css/front/index.css
@@ -18,38 +18,57 @@ section.start a.search-link {
 }
 
 form.index-search-form {
+  display: grid;
+  grid-template-columns: auto max-content;
+  gap: 15px;
   width: 80%;
   max-width: 1000px;
   margin: 0 auto;
   padding: 30px 0;
 }
 
+form.index-search-form > input,
+form.index-search-form > button {
+  display: block;
+  margin: 0;
+  width: 100%;
+  height: 60px;
+  box-sizing: border-box;
+}
+
+form.index-search-form > input:focus {
+  color: var(--white);
+}
+
 form.index-search-form > input[type="text"] {
-  width: 88%;
-  height: 50px;
   font: 44px var(--base-type);
 }
 
+form.index-search-form > input[type="hidden"] {
+  /* This removes it from the grid calculations */
+  position: absolute;
+}
+
 form.index-search-form > button {
-  height: 60px;
+  display: grid;
+  grid-template-columns: auto;
+  align-items: center;
+  padding: 0;
   width: 60px;
-  position: relative;
-  top: 9px;
-  right: 0;
   text-transform: uppercase;
 }
 
 form.index-search-form > button > svg {
+  justify-self: center;
   width: 48px;
   height: 48px;
 }
 
-form.index-search-form > button > label {
-  font-weight: 500;
-  top: 15px;
-  position: relative;
-  font-size: 1.5em;
+form.index-search-form > button > span {
   display: none;
+  margin-top: 3px;
+  font-weight: 500;
+  font-size: 1.5em;
 }
 
 ::placeholder {
@@ -89,33 +108,34 @@ table.index-meta td {
 
 @media only screen and (max-width: 800px) {
   form.index-search-form > input[type="text"] {
-    width: 85%;
-    height: 50px;
     font: 34px var(--base-type);
   }
 }
 
 @media only screen and (max-width: 650px) {
   form.index-search-form > input[type="text"] {
-    width: 80%;
-    height: 50px;
     font: 34px var(--base-type);
   }
 }
 
 @media only screen and (max-width: 480px) {
+  form.index-search-form {
+    grid-template-columns: auto;
+  }
   form.index-search-form > input[type="text"] {
-    width: 99%;
-    height: 50px;
     font: 27px var(--base-type);
   }
 
+  form.index-search-form > input[type="text"],
   form.index-search-form > button {
-    width: 99%;
-    top: 15px;
+    width: 100%;
   }
 
-  form.index-search-form > button > label {
-    display: inline;
+  form.index-search-form > button {
+    grid-template-columns: auto 60px;
+  }
+
+  form.index-search-form > button span {
+    display: block;
   }
 }